-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix HasOneThrough / HasManyThrough relationships #172
Conversation
@goldmont, can you test if this works for you ? Keep in mind your scope will need to fully qualify its field names if they are not unique since this created a join query between multiple tables. |
@bennothommo phpstan is complaining about a method that does not exist even though it does. Not sure about the error on Windows, though... |
Hi, It works now! |
@mjauvin When will it be released? Thanks. |
Not sure. It should be easy to get merged to dev-develop, released is another story as there are no release planned short term. |
Ok, understanding 👍🏻 |
@bennothommo did I ever tell you how much I hate phpstan ? 😛 It's running fine locally now, but barfs in github workflow (see screenshot below): |
@mjauvin which PHP version are you running it on? The GitHub Actions one runs it on PHP 8.2 |
Absolutely no idea why ignoring the |
Most likely 8.3 but I'll need to check tomorrow |
As I thought, this was using php 8.3: [r4l@ahs5] ~/winter/storm $ php -v
PHP 8.3.4 (cli) (built: Mar 15 2024 14:04:12) (NTS)
Copyright (c) The PHP Group
Zend Engine v4.3.4, Copyright (c) Zend Technologies
with Zend OPcache v8.3.4, Copyright (c), by Zend Technologies |
Fixes wintercms/winter#1086
Take
count
&scope
relation configs into account.Also pass the relation name to the constructor.